Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CUDA 12.2 conda and wheel jobs #166

Merged
merged 16 commits into from
Feb 15, 2024
Merged

add CUDA 12.2 conda and wheel jobs #166

merged 16 commits into from
Feb 15, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Dec 20, 2023 •
edited
Loading

Contributes to rapidsai/build-planning#7.
Blocked by rapidsai/ci-imgs#101.

Proposes adding CUDA 12.2.2 jobs for conda and wheel building and testing.

Why these specific matrix entries?

(updated Jan 10)

For building:

For testing

Why not use continue-on-error?

That idea came from a desire to avoid needing to do this "stage a PR in every RAPIDS repo" approach to testing this.

The fact that artifacts like wheels have names that only contain the CUDA major version means that having builds against both CUDA 12.0 and CUDA 12.2 would require hacking in some changes to how artifacts are named and then ensuring that testing knows about those changes (#166 (comment)). That's made more complicated by the fact that many projects have repo-local scripts that do artifact uploading and downloading (#166 (comment)).

Given that, I'm proposing just doing this with the "stage a PR in every RAPIDS repo" approach. And given that, continue-on-error doesn't give us any benefit but WOULD introduce an elevated risk of missing CI failures.

Why not a branch from a fork?

So I can test workflows in other repos like rmm and cudf using the workflows from this branch.

Rollout plan?

  1. get images from add CUDA 12.2 ci-imgs#101 built and published
  2. test this branch on all RAPIDS repos one at a time, in the following order (based on the graph I see at https://github.com/rapidsai/workflows/actions/runs/7405716125), and asking for help from those projects' maintainers if things fail
  3. merge this branch into branch-24.04
  4. another round of PRs to all those projects and switch them back from this branch to branch-24.04 for these workflows
  5. delete this branch

@jameslamb jameslamb changed the title WIP: add CUDA 12.2 wheel jobs WIP: (DO NOT MERGE) add CUDA 12.2 wheel jobs Dec 20, 2023
bdice
bdice reviewed Jan 2, 2024
View reviewed changes
.github/workflows/wheels-test.yaml Outdated Show resolved Hide resolved
.github/workflows/wheels-test.yaml Outdated Show resolved Hide resolved
@bdice bdice mentioned this pull request Jan 2, 2024
Merged
@jameslamb jameslamb mentioned this pull request Jan 4, 2024
Merged
@jameslamb jameslamb marked this pull request as ready for review January 5, 2024 15:20
@jameslamb jameslamb requested a review from bdice January 5, 2024 15:21
@jameslamb jameslamb changed the title WIP: (DO NOT MERGE) add CUDA 12.2 wheel jobs (DO NOT MERGE) add CUDA 12.2 wheel jobs Jan 5, 2024
This was referenced Jan 5, 2024
Merged
Merged
bdice
bdice approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, up to the questions about ARM testing in PRs.

jameslamb and others added 2 commits January 5, 2024 13:57
@jameslamb jameslamb mentioned this pull request Jan 5, 2024
Merged
@jameslamb @bdice
Update .github/workflows/wheels-test.yaml
199bacc 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@jameslamb jameslamb mentioned this pull request Jan 9, 2024
Merged
This was referenced Feb 15, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ajschmidt8 ajschmidt8 merged commit bc93821 into branch-24.04 Feb 15, 2024
@raydouglass raydouglass mentioned this pull request Feb 20, 2024
Merged
@jameslamb jameslamb mentioned this pull request Feb 20, 2024
Merged
6 tasks
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#191)
e011f42 
Follow-up to #161

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #191
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1026)
1b620ae 
Follow-up to #1015

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1026
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1314)
193d72f 
Follow-up to #1302

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1314
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1468)
76bd29d 
Follow-up to #1419

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1468
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#15069)
ef63596 
Follow-up to #14712

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #15069
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#343)
e871389 
Follow-up to #328

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #343
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#702)
e5d1eaf 
Follow-up to #672

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #702
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#2189)
573a034 
Follow-up to #2092

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)
  - https://github.com/jakirkham

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #2189
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#4175)
f78f8d0 
Follow-up to #4088

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)
  - https://github.com/jakirkham

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #4175
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#135)
41728c7 
Follow-up to #116

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #135
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1343)
14ef631 
Follow-up to #1320

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1343
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#571)
af62e4a 
Follow-up to #563

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #571
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#541)
7a3a1cd 
Follow-up to #521

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #541
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Feb 21, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#5776)
f16a8a9 
Follow-up to #5711

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #5776
@jameslamb jameslamb deleted the test-cuda-12.2 branch February 21, 2024 16:30
@jameslamb jameslamb mentioned this pull request Feb 21, 2024
Merged
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this pull request Apr 16, 2024
@jameslamb @younseojava
Support CUDA 12.2 (rapidsai#1302)
1e315a2 
* switches to CUDA 12.2.2 for building conda packages and wheels
* adds new tests running against CUDA 12.2.2

This is part of ongoing work to build and test wheels against CUDA 12.2.2 across all of RAPIDS. For more details see:

* rapidsai/build-planning#7
* rapidsai/shared-workflows#166

### Notes for Reviewers

Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#1302
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this pull request Apr 16, 2024
@jameslamb @younseojava
target branch-24.04 for GitHub Actions workflows (rapidsai#1314)
fec96f3 
Follow-up to rapidsai#1302

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#1314
@bdice bdice mentioned this pull request Jul 9, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice Awaiting requested review from bdice

@ajschmidt8 ajschmidt8 Awaiting requested review from ajschmidt8

Assignees
No one assigned
Labels
breaking Introduces a breaking change improvement Improves an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameslamb @ajschmidt8 @vyasr @bdice