Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store and set the correct CUDA device in device_buffer #1370

Merged
merged 19 commits into from
Nov 15, 2023
Merged

Store and set the correct CUDA device in device_buffer #1370

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c7bf767
Set the device to the owning CUDA device when necessary.
harrism Oct 12, 2023
4633fdf
Add device ID comparison functions and protect against setting device…
harrism Nov 2, 2023
c2656d2
Add missing device reset
harrism Nov 2, 2023
a4d590e
Add tests for containers when switching active CUDA device
harrism Nov 2, 2023
3778c1b
hidden friend operators
harrism Nov 7, 2023
c3a5edf
Move ctor: copy device ID
harrism Nov 7, 2023
14ff4e3
Fix docs
harrism Nov 7, 2023
8cadcd6
Merge branch 'branch-23.12' into fea-device-buffer-multidevice
harrism Nov 8, 2023
082283d
Merge branch 'branch-23.12' into fea-device-buffer-multidevice
harrism Nov 8, 2023
fa2c892
Update include/rmm/device_buffer.hpp
harrism Nov 9, 2023
2381a79
Merge branch 'branch-23.12' into fea-device-buffer-multidevice
harrism Nov 9, 2023
6a403e0
Merge branch 'fea-device-buffer-multidevice' of github.com:harrism/rm…
harrism Nov 9, 2023
c9cd9fb
Hidden friends need not be private
harrism Nov 9, 2023
7168fb0
Attempt to fix weird double friend error from sphinx...
harrism Nov 9, 2023
34bbfde
Don't document hidden friends to try to work around Breathe bug.
harrism Nov 14, 2023
2f56c48
Merge branch 'fea-device-buffer-multidevice' of github.com:harrism/rm…
harrism Nov 14, 2023
d1ef1be
Suppress documentation for hidden friends.
harrism Nov 15, 2023
a70f19d
Typo
harrism Nov 15, 2023
06e080c
clang-format
harrism Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing device reset
  • Loading branch information
@harrism
harrism committed Nov 2, 2023
commit c2656d218df98a42963aa564642f189e2a221136
2 changes: 2 additions & 0 deletions include/rmm/device_buffer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ class device_buffer {
device_buffer& operator=(device_buffer&& other) noexcept
{
if (&other != this) {
cuda_set_device_raii dev{_device};
deallocate_async();

_data = other._data;
Expand Down Expand Up @@ -465,6 +466,7 @@ class device_buffer {
{
if (bytes > 0) {
RMM_EXPECTS(nullptr != source, "Invalid copy from nullptr.");
RMM_EXPECTS(nullptr != _data, "Invalid copy from nullptr.");
harrism marked this conversation as resolved.
Show resolved Hide resolved

RMM_CUDA_TRY(cudaMemcpyAsync(_data, source, bytes, cudaMemcpyDefault, stream().value()));
}
Expand Down