Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proprietary_binary_cuda_version_mapping allows for better CUDA version mapping #648

Merged
merged 1 commit into from
Jul 22, 2024
Merged

proprietary_binary_cuda_version_mapping allows for better CUDA version mapping #648

merged 1 commit into from
Jul 22, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

Allows us to support download urls that have unique mappings per CUDA major version

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard force-pushed the fea/support_more_abitrary_cuda_versions_in_download_url branch from 037a141 to 9c4f694 Compare July 19, 2024 15:56
@robertmaynard
Introduce proprietary_binary_cuda_version_mapping to allow for bett…
19085e4 
…er CUDA version mapping

Allows us to support download urls that have unique mappings
per CUDA major version
@robertmaynard robertmaynard force-pushed the fea/support_more_abitrary_cuda_versions_in_download_url branch from 9c4f694 to 19085e4 Compare July 19, 2024 16:47
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Jul 19, 2024
@robertmaynard robertmaynard marked this pull request as ready for review July 19, 2024 17:04
@robertmaynard robertmaynard requested a review from a team as a code owner July 19, 2024 17:04
vyasr
vyasr approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation seems fine. Can we merge this safely without forcing an immediate bump to 4.0, though, or did they also modify all previous published binaries (I assume not).

@robertmaynard
Copy link
Contributor Author

Implementation seems fine. Can we merge this safely without forcing an immediate bump to 4.0, though, or did they also modify all previous published binaries (I assume not).

We can merge this safely without bumping to 4.0.
The bump to 4.0 requires more work ( As seen in #633 ) so I wanted to pull this out so we could get it reviewed beforehand.

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0feab43 into rapidsai:branch-24.08 Jul 22, 2024
17 of 18 checks passed
@robertmaynard robertmaynard deleted the fea/support_more_abitrary_cuda_versions_in_download_url branch July 22, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @vyasr