Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_architectures output correct CUDA arch values for RAPIDS mode #619

Conversation

robertmaynard
Copy link
Contributor

Description

In RAPIDS mode the local variable CMAKE_CUDA_ARCHITECTURES still was set to OFF and not the updated value. Corrected the code to update the local instance of the variable always before output.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels May 23, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner May 23, 2024 19:31
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d9a8a20 into rapidsai:branch-24.06 May 23, 2024
15 checks passed
@robertmaynard robertmaynard deleted the bug/output_correct_cuda_arch_in_rapids_mode branch May 23, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants