Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output what cuda archs rapids-cmake is building for #609

Merged
merged 5 commits into from
May 22, 2024
Merged

Output what cuda archs rapids-cmake is building for #609

merged 5 commits into from
May 22, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

Fixes #608

Checklist

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels May 21, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner May 21, 2024 13:52
KyleFromNVIDIA
KyleFromNVIDIA approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one minor suggestion, feel free to take it or leave it.

rapids-cmake/cuda/set_architectures.cmake Outdated Show resolved Hide resolved
@robertmaynard @KyleFromNVIDIA
Update rapids-cmake/cuda/set_architectures.cmake
34925bf 
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
vyasr
vyasr approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a style update, but otherwise LGTM

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2f2a3c3 into rapidsai:branch-24.06 May 22, 2024
15 checks passed
@robertmaynard robertmaynard deleted the fea/output_cuda_archs_building_for branch May 22, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Update rapids_cuda_set_architectures to print out the list of architectures being built for
3 participants
@robertmaynard @vyasr @KyleFromNVIDIA