Update CCCL to v2.5.0 #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
approved these changes
Jun 3, 2024
vyasr
added
breaking
bdice
approved these changes
Jun 5, 2024
trxcllnt
commented
Jun 6, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
I think the tests for |
bdice
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
The latest changes look fine to me. I'd like to hear from @robertmaynard in case the testing changes with generating pinned versions are indicative of a problem.
|
/merge |
3 tasks
12 tasks
13 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jun 14, 2024
Now that rapidsai/rapids-cmake#607 has been merged we can drop support for patching CCCL 2.2 Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice) - Paul Taylor (https://github.com/trxcllnt) URL: #15969
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
This PR updates the CCCL version to include a fix for `cuda::std::span` which is required for cuCollections to work properly with CCCL 2.5.0. Most of the changes between the last CCCL version bump (#607) and this one were related to doc updates and unit test fixes, so I don't expect much functional impact for RAPIDS. After this PR we likely have to bump the cuco version again to include the new changes. ### CCCL PR: - NVIDIA/cccl#1836 ### CUCO PR: - NVIDIA/cuCollections#502 ### RAPIDS PRs: - [x] rapidsai/cudf#15986 - [error during docs-build](https://github.com/rapidsai/cudf/actions/runs/9406273871/job/25911619452?pr=15946#step:9:2243) but seems unrelated - [x] rapidsai/cugraph#4483 - some CI jobs ran into a network timeout -> rerunning - [x] rapidsai/cuml#5924 - successful apart from some optional conda python tests - [x] rapidsai/raft#2358 - This one is weird as it [shows an error](https://github.com/rapidsai/raft/actions/runs/9475150045/job/26109283214?pr=2358#step:7:824) that is similar to the one we found in cuco when bumping the CCCL version to 2.5.0. However, we thought the problem was on cuco's end and pushed a fix that resolved the issue (see [Slack thread](https://nvidia.slack.com/archives/CCP05T27R/p1718060955876199)) - [x] rapidsai/rmm#1584 Authors: - Daniel Jünger (https://github.com/sleeepyjack) Approvers: - Bradley Dice (https://github.com/bdice) URL: #631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates CCCL to v2.5.0 and a more recent cuCollections commit.
Using cuco at 6923b3 because it was before NVIDIA/cuCollections#479, which is a breaking change for libcudf.
CCCL PR:
RAPIDS PRs:
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))