Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapids-cmake support empty patches array in json #559

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

This allows overrides to explicitly opt-out of the patches that rapids-cmake lists in the built-in versions.json
Previously you would get a rapids-cmake parsing error when trying to do this.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

This allows overrides to explicitly opt-out of the patches
that rapids-cmake lists in the built-in versions.json
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Mar 12, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner March 12, 2024 17:56
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2ffc72f into rapidsai:branch-24.04 Mar 13, 2024
16 checks passed
@robertmaynard robertmaynard deleted the bug/support_any_patch_arrays branch March 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants