Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scikit-build from dependency list #512

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 19, 2023

Description

This dependency shouldn't be necessary, all of our tests of rapids-cython[-core] just spoof that they're being run via the Python interface while actually running as raw CMake.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general labels Dec 19, 2023
@vyasr vyasr self-assigned this Dec 19, 2023
@bdice
Copy link
Contributor

bdice commented Dec 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit c9a3eeb into rapidsai:branch-24.02 Dec 19, 2023
16 checks passed
@vyasr vyasr deleted the fix/remove_skbuild_dep branch January 10, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants