-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually invoke install rules for components #505
Merged
rapids-bot
merged 7 commits into
rapidsai:branch-24.02
from
vyasr:fix/cccl_component_install
Dec 14, 2023
Merged
Manually invoke install rules for components #505
rapids-bot
merged 7 commits into
rapidsai:branch-24.02
from
vyasr:fix/cccl_component_install
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
Something isn't working
non-breaking
Introduces a non-breaking change
labels
Dec 13, 2023
vyasr
force-pushed
the
fix/cccl_component_install
branch
from
December 13, 2023 18:36
a8ca17d
to
41f527b
Compare
bdice
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on rapidsai/rmm#1404 passing CI.
@vyasr I'm going to merge this - we already discussed adding a test after the fact, which would be helpful to verify the future bug fixes in CCCL. |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CCCL's CMake is currently set up to exit early whenever it's added via
add_subdirectory
, which inadvertently prevents the install rules of its components (Thrust/CUB/libcudacxx) from being called. We don't currently have a way to tell CCCL not to do this because preventing that early exit leads to other undesirable outcomes (such as the CCCL::CCCL targets not being created correctly). Therefore, to work around this we must include the various install rule modules directly until this can be fixed upstream in CCCL.In addition, we require a couple of patches to CCCL's CMake so that 1) the correct config files are installed, and 2) so that multiple invocations of
find_package(CCCL)
will work. These patches have already been fixed on the latest CCCL, see NVIDIA/cccl#298 and NVIDIA/cccl#1157.Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)