Disable NVBench CUPTI support by default. #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
robertmaynard
approved these changes
Dec 12, 2023
|
/merge |
This was referenced Jan 11, 2024
This was referenced Jan 22, 2024
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jan 22, 2024
The `-DNVBench_ENABLE_CUPTI=OFF` flag is no longer needed because of rapidsai/rapids-cmake#504. NVBench CUPTI support is now disabled by default. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #14820
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Feb 26, 2024
The `-DNVBench_ENABLE_CUPTI=OFF` flag is no longer needed because of rapidsai/rapids-cmake#504. NVBench CUPTI support is now disabled by default. Authors: - Bradley Dice (https://github.com/bdice) - Paul Taylor (https://github.com/trxcllnt) Approvers: - Ray Douglass (https://github.com/raydouglass) - Mark Harris (https://github.com/harrism) URL: #1325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables CUPTI support in NVBench by default.
In essentially all of RAPIDS, we have to set
NVBench_ENABLE_CUPTI OFF. By default, this is enabled, but it leads to several problems. First, when CUPTI support is enabled, the benchmark executables require the same CUDA major.minor version at runtime, meaning that (for instance) we can't build with CUDA 11.8 and expect that the benchmarks can be run with CUDA 11.5. Generally RAPIDS wants to produce builds that follow rules for CUDA minor version compatibility within a CUDA major version. Secondly, developers (especially new developers building from source) frequently run into issues where CUPTI is not available. We don't makecuda-cupti-deva conda dependency in cudf, specifically because we disable CUPTI support most of the time. However, users building from source or using their own build invocations won't have CUPTI disabled, and run into problems compiling because of this missing dependency.Examples:
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))