Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor layout to enable adding CI and Documentation #5

Merged
merged 1 commit into from
May 10, 2021

Conversation

robertmaynard
Copy link
Contributor

The original layout of rapids-cmake mixes support directories ( testing ) with directories holding rapids-cmake function ( cpm, export ). As we introduce more support functionality such as documentation, or try to provide test support functions this mixture will make it harder for users to discover functionality.

This PR moves all rapids-cmake functions into the rapids-cmake folder. This will make it easier for users/developers to know the intention of each folder in rapids-cmake.

This shouldn't break backwards compat, as the root CMakeLists.txt has been updated so that the following pattern still works:

include(FetchContent)
FetchContent_Declare(
  rapids-cmake
  GIT_REPOSITORY git@github.com:rapidsai/rapids-cmake.git
  GIT_TAG        origin/main
  )
FetchContent_MakeAvailable(rapids-cmake)
include(rapids-cmake)
include(rapids-cpm)
include(rapids-cuda)
include(rapids-export)
include(rapids-find)

@robertmaynard robertmaynard merged commit 6487398 into rapidsai:branch-0.20 May 10, 2021
@robertmaynard robertmaynard deleted the refactor_layout branch May 10, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant