Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rapids_cpm_cccl feature. #495

Merged
merged 15 commits into from
Dec 7, 2023
Merged

Add rapids_cpm_cccl feature. #495

merged 15 commits into from
Dec 7, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 1, 2023 •
edited
Loading

Description

This PR adds a new function rapids_cpm_cccl that adds CCCL from the new monorepo. This will eventually replace rapids_cpm_thrust and rapids_cpm_libcudacxx.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 1, 2023
robertmaynard
robertmaynard requested changes Dec 5, 2023
View reviewed changes
rapids-cmake/cpm/cccl.cmake Outdated Show resolved Hide resolved
rapids-cmake/cpm/cccl.cmake Outdated Show resolved Hide resolved
rapids-cmake/cpm/cccl.cmake Outdated Show resolved Hide resolved
rapids-cmake/cpm/cccl.cmake Show resolved Hide resolved
@bdice bdice marked this pull request as ready for review December 7, 2023 02:28
@bdice bdice requested review from a team as code owners December 7, 2023 02:28
@bdice bdice self-assigned this Dec 7, 2023
@bdice
Copy link
Contributor Author

bdice commented Dec 7, 2023

@robertmaynard I think this is ready for a proper review. I'm not sure what else needs to be done. It seems like things are working properly in my downstream tests of rmm, cudf, and raft (in local builds and also this cudf PR: rapidsai/cudf#14576).

@bdice bdice mentioned this pull request Dec 7, 2023
Merged
This was referenced Dec 7, 2023
Merged
Merged
Merged
robertmaynard
robertmaynard approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, presuming the cuCollection changes will be removed

bdice
bdice commented Dec 7, 2023
View reviewed changes
rapids-cmake/cpm/versions.json Outdated Show resolved Hide resolved
@bdice bdice removed the request for review from a team December 7, 2023 14:55
@bdice
Copy link
Contributor Author

bdice commented Dec 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit c3b7afc into rapidsai:branch-24.02 Dec 7, 2023
17 checks passed
@bdice bdice mentioned this pull request Dec 7, 2023
Closed
7 tasks
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this pull request Dec 19, 2023
@bdice
Update to CCCL 2.2.0. (#1404)
a4dd4f5 
This PR updates RMM to CCCL 2.2.0. Do not merge until all of RAPIDS is ready to update.

Depends on rapidsai/rapids-cmake#495.

Replaces #1247.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@bdice bdice

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @robertmaynard