Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function usages #484

Merged

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Nov 13, 2023

Description

Remove usage of function signatures that are no longer supported in 24.02

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Nov 13, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner November 13, 2023 16:41
@bdice
Copy link
Contributor

bdice commented Nov 13, 2023

image
Is this referencing the previous gpuCI system? Is something set wrong in the branch protections?

@bdice
Copy link
Contributor

bdice commented Nov 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6390a1d into rapidsai:branch-24.02 Nov 13, 2023
16 checks passed
@robertmaynard robertmaynard deleted the bug/remove_deprecated_usages branch November 13, 2023 18:56
@cryos
Copy link

cryos commented Dec 15, 2023

This looks like it should have also made it into the 23.12 branch, I am seeing deprecation warnings if I use 23.12 that this patch would silence when calling rapids_find_generate_module.

@robertmaynard
Copy link
Contributor Author

This looks like it should have also made it into the 23.12 branch, I am seeing deprecation warnings if I use 23.12 that this patch would silence when calling rapids_find_generate_module.

Yeah it should have. Since it is just a diagnostic bug I think it isn't worth releasing a 23.12 patch release of rapids-cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants