Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rapids_test to be used without CUDAToolkit #480

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

Fixes #478

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Oct 24, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner October 24, 2023 17:53
Copy link
Contributor

@Jacobfaib Jacobfaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues. Also another more minor nit, the configure steps here are quite chatty:

-- Could not find nvcc, please set CUDAToolkit_ROOT.
'/opt/homebrew/opt/ccache/libexec/c++' '/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp' '-o' '/path/to/rapids-cmake/generate_ctest_json'

Is it possible to silence these unless there is a problem (or extra verbosity is requested)? The first message implies there is a problem (which there isn't), while the second is not useful for the user to see unless there is an issue.

rapids-cmake/test/detail/generate_resource_spec.cpp Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

A few minor issues. Also another more minor nit, the configure steps here are quite chatty:

-- Could not find nvcc, please set CUDAToolkit_ROOT.
'/opt/homebrew/opt/ccache/libexec/c++' '/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp' '-o' '/path/to/rapids-cmake/generate_ctest_json'

Is it possible to silence these unless there is a problem (or extra verbosity is requested)? The first message implies there is a problem (which there isn't), while the second is not useful for the user to see unless there is an issue.

Can you try the updated version again, please? All your issues should be resolved now

@Jacobfaib
Copy link
Contributor

Jacobfaib commented Nov 2, 2023

Can you try the updated version again, please? All your issues should be resolved now

OK tried latest 07e58cd, and it seems that the build is still outputting the following:

'/opt/homebrew/opt/ccache/libexec/c++' '/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp' '-o' '/path/to/rapids-cmake/generate_ctest_json'

From what I can tell this is due to the compile command having the COMMAND_ECHO STDOUT option set. Perhaps this can be directed into a variable instead?

Also, I'm sure CI will flag this momentarily, but...

/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp:43:76: error: no member named 'minor' in 'version'
  buffer << "\"version\": {\"major\": " << v.major << ", \"minor\": " << v.minor << "}";
                                                                         ~ ^

@robertmaynard
Copy link
Contributor Author

Can you try the updated version again, please? All your issues should be resolved now

OK tried latest 07e58cd, and it seems that the build is still outputting the following:

'/opt/homebrew/opt/ccache/libexec/c++' '/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp' '-o' '/path/to/rapids-cmake/generate_ctest_json'

From what I can tell this is due to the compile command having the COMMAND_ECHO STDOUT option set. Perhaps this can be directed into a variable instead?

Also, I'm sure CI will flag this momentarily, but...

/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp:43:76: error: no member named 'minor' in 'version'
  buffer << "\"version\": {\"major\": " << v.major << ", \"minor\": " << v.minor << "}";
                                                                         ~ ^

Yeah I missed the COMMAND_ECHO, thanks. Removed that and only dump the compile info when we fail.

@Jacobfaib
Copy link
Contributor

OK, with a quick fixup to fix that compile error above, the latest LGTM.

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ae1c8e8 into rapidsai:branch-23.12 Nov 2, 2023
16 checks passed
@robertmaynard robertmaynard deleted the fea/testing_support_cpu_only branch November 2, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Allow rapids_test to be used without CUDAToolkit
2 participants