-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow rapids_test to be used without CUDAToolkit #480
Allow rapids_test to be used without CUDAToolkit #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor issues. Also another more minor nit, the configure steps here are quite chatty:
-- Could not find nvcc, please set CUDAToolkit_ROOT.
'/opt/homebrew/opt/ccache/libexec/c++' '/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp' '-o' '/path/to/rapids-cmake/generate_ctest_json'
Is it possible to silence these unless there is a problem (or extra verbosity is requested)? The first message implies there is a problem (which there isn't), while the second is not useful for the user to see unless there is an issue.
Can you try the updated version again, please? All your issues should be resolved now |
OK tried latest 07e58cd, and it seems that the build is still outputting the following: '/opt/homebrew/opt/ccache/libexec/c++' '/path/to/_deps/rapids-cmake-src/rapids-cmake/test/detail/generate_resource_spec.cpp' '-o' '/path/to/rapids-cmake/generate_ctest_json' From what I can tell this is due to the compile command having the Also, I'm sure CI will flag this momentarily, but...
|
Yeah I missed the |
OK, with a quick fixup to fix that compile error above, the latest LGTM. |
/merge |
Description
Fixes #478
Checklist
cmake-format.json
is up to date with these changes.