Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patch for libcudacxx memory resource. #476

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add patch for libcudacxx memory resource. #476

merged 1 commit into from
Oct 17, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 17, 2023

Description

Adds a patch from NVIDIA/libcudacxx#439 for libcudacxx 2.1.0, to support ongoing memory resource work.

cc: @miscco

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice force-pushed the libcudacxx-memory-resource-patch branch from 2e41f3d to ef925bb Compare October 17, 2023 17:28
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 17, 2023
@bdice bdice self-assigned this Oct 17, 2023
@miscco
Copy link
Contributor

miscco commented Oct 17, 2023

Thanks a lot, totally forget to remove the testing changes from the patch I send you

@bdice bdice marked this pull request as ready for review October 17, 2023 19:51
@bdice
Copy link
Contributor Author

bdice commented Oct 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6269046 into rapidsai:branch-23.12 Oct 17, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@bdice bdice

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @miscco @robertmaynard