Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Python version in dependencies.yaml. #470

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 4, 2023

Description

This PR adds py_version to the dependencies.yaml file so that rapids-cmake expresses this in the same way as every other RAPIDS repository. The primary reason this might matter is for ensuring that compatible Python versions are used for style checks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice self-assigned this Oct 4, 2023
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 4, 2023
vyasr
vyasr approved these changes Oct 9, 2023
@vyasr
Copy link
Contributor

vyasr commented Oct 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3742838 into rapidsai:branch-23.12 Oct 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants