Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote the list of patch files in case they have spaces in their paths #463

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Quote the list of patch files in case they have spaces in their paths #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a43ac
Quote the list of patch files in case they have spaces in their paths
ericniebler Sep 22, 2023
7eb1b54
Expand test to verify we quote file paths
robertmaynard Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rapids-cmake/cpm/patches/command_template.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function(rapids_cpm_run_git_patch file issue)
set(msg_state ${msg_state} PARENT_SCOPE)
endfunction()

set(files @patch_files_to_run@)
set(files "@patch_files_to_run@")
set(issues "@patch_issues_to_ref@")
set(output_file "@log_file@")
foreach(file issue IN ZIP_LISTS files issues)
Expand Down
9 changes: 7 additions & 2 deletions testing/cpm/cpm_generate_patch_command-current_json_dir.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#=============================================================================
# Copyright (c) 2022, NVIDIA CORPORATION.
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -38,6 +38,11 @@ file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/override.json
"file" : "${current_json_dir}/example.diff",
"issue" : "explain",
"fixed_in" : ""
},
{
"file" : "${current_json_dir}/example2.diff",
"issue" : "explain",
"fixed_in" : ""
}
]
}
Expand All @@ -51,7 +56,7 @@ if(NOT patch_command)
message(FATAL_ERROR "rapids_cpm_package_override specified a patch step for `pkg_with_patch`")
endif()

set(to_match_string "set(files ${CMAKE_CURRENT_BINARY_DIR}/example.diff)")
set(to_match_string "set(files \"${CMAKE_CURRENT_BINARY_DIR}/example.diff;${CMAKE_CURRENT_BINARY_DIR}/example2.diff\")")

list(POP_BACK patch_command script_to_run)
file(READ "${script_to_run}" contents)
Expand Down