Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CPM v0.38.5 #460

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Update to CPM v0.38.5 #460

merged 3 commits into from
Sep 21, 2023

Conversation

trxcllnt
Copy link
Contributor

Description

Update to CPM v0.38.5.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@trxcllnt trxcllnt requested a review from a team as a code owner September 19, 2023 21:42
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 19, 2023
@robertmaynard
Copy link
Contributor

Unless we absolutely need this for 23.10 lets merge this first for 23.12 so we have lots of time to find and fix issues

@trxcllnt
Copy link
Contributor Author

@robertmaynard CPM v0.38 is the one that added support for add_subdirectory(... [SYSTEM]), which is the feature that motivated this particular PR. Is upgrading CPM really that risky?

@robertmaynard
Copy link
Contributor

I didn't know if this was a simple version bump to keep up to date, or for new features.
Since we have a need for add_subdirectory(SYSTEM) I am good with adding this to 23.10

@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit d34d989 into branch-23.10 Sep 21, 2023
14 checks passed
@robertmaynard robertmaynard deleted the fea/update-to-cpm-v0.38.5 branch March 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants