Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests the modify same git repo don't execute at the same time #446

Conversation

robertmaynard
Copy link
Contributor

Description

A subset of the rapids_cpm tests modify the same git repo active branch which isn't safe. We need to serialize those tests to ensure everything works robustly.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team labels Jul 25, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner July 25, 2023 18:15
@robertmaynard robertmaynard added the non-breaking Introduces a non-breaking change label Jul 25, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one minor comment). Thanks!

testing/utils/cmake_test.cmake Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2787398 into rapidsai:branch-23.08 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants