Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When nvcomp is found locally print where it is on disk #434

Conversation

robertmaynard
Copy link
Contributor

Description

This way users always get some console output for where nvcomp is located. We don't remove the QUIET request since that would print out the following:

  CMake Warning at ..../rapids-cmake/find/package.cmake:125 (find_package):
  By not providing "Findnvcomp.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "nvcomp", but
  CMake did not find one.

  Could not find a package configuration file provided by "nvcomp" (requested
  version 2.6.1) with any of the following names:

    nvcompConfig.cmake
    nvcomp-config.cmake

  Add the installation prefix of "nvcomp" to CMAKE_PREFIX_PATH or set
  "nvcomp_DIR" to a directory containing one of the above files.  If "nvcomp"
  provides a separate development package or SDK, be sure it has been
  installed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

This way users always get some console output for where nvcomp
is located. We don't remove the `QUIET` request since that
would print out the following:

```
  CMake Warning at ..../rapids-cmake/find/package.cmake:125 (find_package):
  By not providing "Findnvcomp.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "nvcomp", but
  CMake did not find one.

  Could not find a package configuration file provided by "nvcomp" (requested
  version 2.6.1) with any of the following names:

    nvcompConfig.cmake
    nvcomp-config.cmake

  Add the installation prefix of "nvcomp" to CMAKE_PREFIX_PATH or set
  "nvcomp_DIR" to a directory containing one of the above files.  If "nvcomp"
  provides a separate development package or SDK, be sure it has been
  installed.
```
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jun 30, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner June 30, 2023 16:16
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 965321e into rapidsai:branch-23.08 Jul 5, 2023
@robertmaynard robertmaynard deleted the bug/nvcomp_report_local_version_found branch July 5, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant