support_conda_env support host and build CTK 12 locations #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For cuda 12+ the conda layout has CTK components in both host and build. Update the CMAKE_PREFIX search locations and rpath-link entries for this new layout.
robertmaynard
added
feature request
|
I'll try to test this downstream in rapidsai/kvikio#224. |
bdice
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
This fixes the issues seen in rapidsai/kvikio#224. I have only a minor suggestion for improving a comment.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
vyasr
requested changes
Jun 13, 2023
vyasr
approved these changes
Jun 13, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For cuda 12+ the conda layout has CTK components in both host and build. Update the CMAKE_PREFIX search locations and rpath-link entries for this new layout.
Checklist
cmake-format.jsonis up to date with these changes.