rapids_cpm cccl packages cmake files are now relocated to not clash with upstream #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rapidsai#367 This way rapids-cmake versions of these projects don't clash with the upstream versions.
robertmaynard
added
breaking
bdice
approved these changes
Mar 27, 2023
robertmaynard
force-pushed
the
bug/install_cccl_cmake_modules_in_namespace
branch
2 times, most recently
from
ffc1f7c
to
cfd5f72
Compare
bdice
approved these changes
Apr 11, 2023
robertmaynard
force-pushed
the
bug/install_cccl_cmake_modules_in_namespace
branch
from
cfd5f72
to
7455f36
Compare
|
I do plan to review this PR, just haven't gotten around to it quite yet. |
vyasr
reviewed
Apr 19, 2023
There was a problem hiding this comment.
I would recommend changing the title to more clearly indicate that what this PR is doing is relocating where rapids-cmake installs CCCL packages. Vendor sounds like the files are embedded in some way, and tbh I was expecting this PR to be about creating a rapids-cmake conda package containing the rapids-specific CCCL dependencies before I read through it.
vyasr
approved these changes
Apr 20, 2023
bdice
reviewed
Apr 23, 2023
robertmaynard
changed the title
3 tasks
|
@robertmaynard can we merge this now? Then we can also finalize rapidsai/cudf#13235 |
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
May 30, 2023
Depends on: rapidsai/rapids-cmake#393 Once the above PR is merged, this updated logic ensures that cudf places the custom versions of cccl packages in correct places, and can find them once installed. Authors: - Robert Maynard (https://github.com/robertmaynard) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #13235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This way rapids-cmake versions of these projects don't clash with the upstream versions.
Fixes #367
Checklist
cmake-format.jsonis up to date with these changes.