Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support static builds of fmt #372

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Support static builds of fmt #372

merged 3 commits into from
Feb 14, 2023

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Feb 14, 2023 •
edited
Loading

Description

By default fmt doesn't set the POSITION_INDEPENDENT_CODE value on targets when built statically. This causes link errors when the static library is consumed by a shared library.

Checklist

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Feb 14, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner February 14, 2023 16:00
@robertmaynard robertmaynard added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Feb 14, 2023
@robertmaynard
Copy link
Contributor Author

robertmaynard commented Feb 14, 2023 •
edited
Loading

Need to add a test that uses fmt statically.

Edit: Test added.

@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team and removed 4 - Waiting on Author Waiting for author to respond to review labels Feb 14, 2023
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b9ddca1 into rapidsai:branch-23.04 Feb 14, 2023
@robertmaynard robertmaynard deleted the bug/fmt_support_static_builds branch February 14, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice