Use trap to handle errors in test scripts

[AjayThorve]

This PR adds a less verbose trap method, for error handling to help ensure that we capture all potential error codes in our test scripts, and works as follows:

• setting an environment variable, EXITCODE, with a default value of 0
• setting a trap statement triggered by ERR signals which will set EXITCODE=1 when any commands return a non-zero exit code

cc @ajschmidt8

[robertmaynard]

I am confused.

The PR title is Reduce error handling verbosity in CI tests scripts but the scripts are now longer. What verbosity is this intending to reduce?

[ajschmidt8]

I am confused.

The PR title is Reduce error handling verbosity in CI tests scripts but the scripts are now longer. What verbosity is this intending to reduce?

Good point. This change doesn't have much effect on rapids-cmake since it's test scripts are pretty succinct.

In other repositories, these changes were meant to replace the many conditional code blocks that existed previously for capturing error codes (like this file for cudf).

@robertmaynard, if you want us to close this PR since rapids-cmake has a small test script that's fine. I initially just created a list of all the GHAs repositories that should be checked which is why this PR was opened.

[AjayThorve]

I am confused.

The PR title is Reduce error handling verbosity in CI tests scripts but the scripts are now longer. What verbosity is this intending to reduce?

Hey @robertmaynard, you are right. This PR was part of a larger effort across all repos, and the title applied to all the repos except rapids-cmake. Infact in this case, as you mentioned it's adding more lines. Apologies for the confusion, but the aim of the change is to use the trap method to catch ERR, and while in most repositories across rapidsai, it significantly reduced the verbosity, in the case of rapids-cmake, we can may be use trap to keep error handling consistent across projects?

[robertmaynard]

Absolutely fine moving over to using trap. Let's just update the pr title

[ajschmidt8]

/merge