Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for pulling cuCollections using rapids-cmake #201

Merged
merged 20 commits into from
Jun 16, 2022
Merged

Adds support for pulling cuCollections using rapids-cmake #201

merged 20 commits into from
Jun 16, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 16, 2022

This PR allows us to standardize cuco usage across RAPIDS.

@vyasr vyasr added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jun 16, 2022
@vyasr vyasr self-assigned this Jun 16, 2022
@vyasr vyasr requested a review from a team as a code owner June 16, 2022 17:41
robertmaynard
robertmaynard requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the docs to expose rapids_cpm_cuco

So add a rapids_cpm_cuco.rst to docs/packages and add an entry to docs/api.rst

robertmaynard
robertmaynard requested changes Jun 16, 2022
View reviewed changes
rapids-cmake/cpm/cuco.cmake Show resolved Hide resolved
rapids-cmake/cpm/cuco.cmake Outdated Show resolved Hide resolved
testing/cpm/CMakeLists.txt Outdated Show resolved Hide resolved
robertmaynard
robertmaynard requested changes Jun 16, 2022
View reviewed changes
rapids-cmake/cpm/cuco.cmake Outdated Show resolved Hide resolved
testing/cpm/cpm_cuco-exports.cmake Outdated Show resolved Hide resolved
testing/cpm/cpm_cuco-simple.cmake Outdated Show resolved Hide resolved
robertmaynard
robertmaynard approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

bdice
bdice reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice change. Comments attached. (I reviewed this to help familiarize myself with more of rapids-cmake.)

testing/cpm/CMakeLists.txt Outdated Show resolved Hide resolved
rapids-cmake/cpm/versions.json Show resolved Hide resolved
rapids-cmake/cpm/versions.json Show resolved Hide resolved
testing/cpm/cpm_cuco-simple.cmake Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Jun 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 048e269 into rapidsai:branch-22.08 Jun 16, 2022
@vyasr vyasr deleted the rapids-cpm-cuco branch June 22, 2022 17:31
This was referenced Jun 22, 2022
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Jun 23, 2022
@vyasr
Update get_cucollections to use rapids-cmake (#11139)
6cc498f 
This ensures that a consistent cuco version is used across all of RAPIDS. See rapidsai/rapids-cmake#201.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #11139
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Jun 27, 2022
@vyasr
Use rapids-cmake for cuco (#722)
5c827de 
This ensures that a consistent cuco version is used across all of RAPIDS. See rapidsai/rapids-cmake#201 and rapidsai/cudf#11139

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @robertmaynard @bdice