Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose linalg::dot in public API #968

Merged
merged 14 commits into from
Nov 10, 2022
Merged

Expose linalg::dot in public API #968

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
01dd067
Expose `linalg::dot` in public API
benfred Oct 31, 2022
e6a5bb1
formatting
benfred Oct 31, 2022
400dfa9
Merge branch 'branch-22.12' into linalg_dot
benfred Nov 1, 2022
f376c51
Updates from code review
benfred Nov 1, 2022
9c9efe8
Update axpy to take a device_vector_view
benfred Nov 1, 2022
2bf4eae
Changes from codereview
benfred Nov 8, 2022
2e1c0e6
remove dot w/ host pointer overload
benfred Nov 8, 2022
a668098
Added docs / created 'make_strided_layout' factory function
benfred Nov 8, 2022
977949f
Add doxygen for make_strided_layout
benfred Nov 9, 2022
a125c4f
fix
benfred Nov 9, 2022
6f8a76c
Test out host and device api's
benfred Nov 9, 2022
af52c0c
Merge remote-tracking branch 'origin/branch-22.12' into linalg_dot
benfred Nov 9, 2022
25333ee
test out both device/host alpha scalar overloads with dot
benfred Nov 9, 2022
98f7d85
Fix docstring
benfred Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@benfred
benfred committed Nov 9, 2022
commit a125c4f7ea5b90cdd7b0e81ac7c980553f0a03ce
2 changes: 1 addition & 1 deletion cpp/include/raft/core/device_mdspan.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ auto make_device_vector_view(
template <typename Extents, typename Strides>
auto make_strided_layout(Extents extents, Strides strides)
{
return layout_stride::mapping<ExtentType>{extents, strides};
return layout_stride::mapping<Extents>{extents, strides};
}

/**
Expand Down