Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdspanifying (currently tested) raft::matrix #846

Merged
Merged
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
5d697b3
Breaking apart mdspan/mdarray into host_ and device_ variants
cjnolet Sep 7, 2022
0e6cc86
Updates
cjnolet Sep 7, 2022
71922f6
Fixing style
cjnolet Sep 7, 2022
b0e5a02
Separating host_span and device_span as well
cjnolet Sep 7, 2022
d69b163
Cleanup and getting to build
cjnolet Sep 7, 2022
50d750b
Updates
cjnolet Sep 7, 2022
6fda1fd
Fixing docs
cjnolet Sep 8, 2022
dded6ed
Updating readme to use proper header paths
cjnolet Sep 8, 2022
3aeb530
More updates based on review feedback
cjnolet Sep 8, 2022
ca354f3
Mdspanifying spatial/knn functions
cjnolet Sep 14, 2022
46b0750
Getting knn test to build
cjnolet Sep 14, 2022
a52bd9c
Merge branch 'branch-22.10' into fea-2210-mdspanified_knn
cjnolet Sep 14, 2022
76a469d
Merge branch 'branch-22.10' into imp-2210-host_device_mdspan
cjnolet Sep 14, 2022
b6c758c
Fixing style
cjnolet Sep 14, 2022
3838690
Merge branch 'imp-2210-host_device_mdspan' into fea-2210-mdspanified_knn
cjnolet Sep 15, 2022
105a3a6
Trying to FIND_RAFT_CPP on by default
cjnolet Sep 15, 2022
7eae6e3
Fixing bad merge
cjnolet Sep 15, 2022
019e358
Merge remote-tracking branch 'rapidsai/branch-22.10' into imp-2210-ho…
cjnolet Sep 15, 2022
08c5648
Merge branch 'imp-2210-host_device_mdspan' into fea-2210-mdspanified_knn
cjnolet Sep 15, 2022
141a2d1
Fixing knn wrapper
cjnolet Sep 19, 2022
6cd27af
mdspanidying random ball cover
cjnolet Sep 19, 2022
4870554
mdspan-ifying ivf_flat, rbc, and epsilon neighborhoods
cjnolet Sep 19, 2022
428a9e6
Fixing last compile error
cjnolet Sep 19, 2022
a612bc2
Updating ball cover specializations and API
cjnolet Sep 20, 2022
e63d121
Removing stream destroy from eps neigh tests
cjnolet Sep 20, 2022
44f7aca
Starting on col wise sort
cjnolet Sep 20, 2022
d111743
Updating docs
cjnolet Sep 20, 2022
13d23fd
Merge branch 'fea-2210-mdspanified_knn' into fea-2210-mdspanified_matrix
cjnolet Sep 20, 2022
3a14fa5
MOre gather and colwise sort
cjnolet Sep 21, 2022
f27b0cb
Breaking matrix functions out into individual files.
cjnolet Sep 21, 2022
b1e834c
Merge branch 'branch-22.10' into fea-2210-mdspanified_knn
cjnolet Sep 22, 2022
32a9a34
Merge branch 'branch-22.10' into fea-2210-mdspanified_matrix
cjnolet Sep 22, 2022
9002337
Fixing style
cjnolet Sep 22, 2022
6c34351
Fixing style for tests
cjnolet Sep 22, 2022
fea8448
iUpdates
cjnolet Sep 26, 2022
bbf2ab1
Updates based on review feedback
cjnolet Sep 26, 2022
f528697
Updates based on review feedback
cjnolet Sep 26, 2022
90bbb33
Getting to nbuild
cjnolet Sep 26, 2022
8cb3ec5
Fixing style
cjnolet Sep 26, 2022
c4bd2d1
Removing files from raft;:Matrix which still need to be tested
cjnolet Sep 26, 2022
b166814
Progress on matrix API
cjnolet Sep 27, 2022
4c552bc
Adding weight back into rbc
cjnolet Sep 27, 2022
53a254e
Style check
cjnolet Sep 27, 2022
278ce4d
More updates
cjnolet Sep 27, 2022
14c4ff1
Trying to figure out gather and linewise op
cjnolet Sep 27, 2022
8db49ab
Still trying to figure out why gaqther isn't being invoked
cjnolet Sep 27, 2022
4ea623f
Style fix
cjnolet Sep 27, 2022
d5db8e3
Merge remote-tracking branch 'rapidsai/branch-22.10' into fea-2210-md…
cjnolet Sep 27, 2022
477d18a
Finisxhing up matrix
cjnolet Sep 27, 2022
f63b458
Getting tests to pass. Still need to figure out linewise_op failures
cjnolet Sep 28, 2022
7edf83a
Cleaning up, docs, tests passing. ready for review
cjnolet Sep 28, 2022
5b705d7
More docs cleanup
cjnolet Sep 28, 2022
b49c9f4
Updates
cjnolet Sep 28, 2022
5fa5bbf
Implementing review feedback
cjnolet Sep 29, 2022
ce94f63
Renaming
cjnolet Sep 29, 2022
9939464
Updating docs to include [in] and [out]
cjnolet Sep 29, 2022
32775a6
Syncing handle after argmax prim
cjnolet Sep 29, 2022
5363a2d
Removing defaults on template args
cjnolet Sep 30, 2022
b4377cb
Merge branch 'branch-22.10' into fea-2210-mdspanified_knn
cjnolet Sep 30, 2022
dec2f81
Adding limit-tests to build.sh. Removing default template args per
cjnolet Sep 30, 2022
b70b44b
Updating docs
cjnolet Sep 30, 2022
e25caef
More style cleanup
cjnolet Sep 30, 2022
37ae236
Pulling out argmax for now since the test seems to be failing in centos.
cjnolet Sep 30, 2022
423034b
Merge branch 'fea-2210-mdspanified_knn' into fea-2210-mdspanified_mat…
cjnolet Sep 30, 2022
9ce7d4f
Lots of updates from review feedback.
cjnolet Sep 30, 2022
5313cb9
Merge branch 'branch-22.10' into fea-2210-mdspanified_knn
cjnolet Sep 30, 2022
c024518
Merge branch 'fea-2210-mdspanified_knn' into fea-2210-mdspanified_mat…
cjnolet Sep 30, 2022
3db8a27
Moving re-defined validation logic out of mdspan.hpp
cjnolet Sep 30, 2022
4c06e91
Review feedback
cjnolet Oct 2, 2022
946bfcb
More review feedbck
cjnolet Oct 2, 2022
c7245f6
Merge branch 'branch-22.10' into fea-2210-mdspanified_matrix_tested
cjnolet Oct 2, 2022
e0e5eae
Fixing styl
cjnolet Oct 2, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing stream destroy from eps neigh tests
  • Loading branch information
cjnolet committed Sep 20, 2022
commit e63d121e9ff85337c63c12a6eb9d916e9b0114e0
2 changes: 0 additions & 2 deletions cpp/test/spatial/epsilon_neighborhood.cu
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ class EpsNeighTest : public ::testing::TestWithParam<EpsInputs<T, IdxT>> {
false);
}

void TearDown() override { RAFT_CUDA_TRY(cudaStreamDestroy(stream)); }

EpsInputs<T, IdxT> param;
cudaStream_t stream = 0;
rmm::device_uvector<T> data;
Expand Down