Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pylibraft with scikit-build #633

Merged
merged 39 commits into from
May 13, 2022
Merged

Build pylibraft with scikit-build #633

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
6b5e80d
Add _skbuild to gitignore.
vyasr Apr 27, 2022
f38cfbd
Initial version with skbuild.
vyasr Apr 27, 2022
6287c1b
Rework add_cython_modules to support passing in the list of libraries.
vyasr Apr 27, 2022
a0c5d54
Rework add_cython_modules to support passing in the base directory fo…
vyasr Apr 27, 2022
f0dcb67
Switch to using new rapids-cmake function for creating cython modules.
vyasr Apr 27, 2022
7b04525
Remove skbuild patch and rely on rapids-cmake.
vyasr Apr 27, 2022
a05ef51
Standardize some more boilerplate and add TODOs.
vyasr Apr 27, 2022
12fe3ce
Update build to use newest rapids-cython code.
vyasr May 4, 2022
3b5dc46
Rename project to pylibraft.
vyasr May 4, 2022
a1ec517
Rename cython_modules to cython_sources.
vyasr May 4, 2022
6dc4c8f
Remove outdated TODO.
vyasr May 4, 2022
65a2d04
Add pyproject.toml and remove superfluous components of setup.py.
vyasr May 4, 2022
381df61
Update conda files.
vyasr May 4, 2022
87f44f4
Update update_version.sh and the name of the version variable in CMak…
vyasr May 4, 2022
1e8dc7e
Improve formatting of build.sh.
vyasr May 4, 2022
d805dd4
Update relevant parts of build.sh.
vyasr May 4, 2022
920bade
Update rapids-cmake link now that rapids-cython is merged.
vyasr May 6, 2022
517527a
Set the language level.
vyasr May 6, 2022
abd5bc0
Revert "Update rapids-cmake link now that rapids-cython is merged."
vyasr May 6, 2022
f1c6642
Add support for passing arbitrary CMake arguments through the build s…
vyasr May 6, 2022
5565ec2
Find CPP raft when building with conda.
vyasr May 6, 2022
d1c62f2
Fix quotes.
vyasr May 6, 2022
38a99a0
Revert "Revert "Update rapids-cmake link now that rapids-cython is me…
vyasr May 6, 2022
ba3a641
Revert "Set the language level."
vyasr May 6, 2022
40908ff
Fix finding raft CPP.
vyasr May 6, 2022
59cb1ac
Set options early and use them everywhere.
vyasr May 6, 2022
47c2e4a
Install raft_distance headers.
vyasr May 6, 2022
60956db
Remove unnecessary extra variables set.
vyasr May 7, 2022
0e7a18e
Add rapids cmake download line to update-version.sh.
vyasr May 7, 2022
8e75eef
Conditionally enable CUDA when building the CPP library.
vyasr May 7, 2022
3532571
Minor reformatting.
vyasr May 7, 2022
ef27476
Add comment to language enabling.
vyasr May 7, 2022
549c765
Merge remote-tracking branch 'origin/branch-22.06' into feature/skbuild
vyasr May 11, 2022
fb28a5d
Fail to build the Python library if linking against a pre-built C++ l…
vyasr May 12, 2022
2729be0
Merge remote-tracking branch 'origin/branch-22.06' into feature/skbuild
vyasr May 12, 2022
36c26af
Final cleanup, testing against new branch with RUNPATH set to ORIGIN.
vyasr May 12, 2022
c42bacd
Properly initialize architectures when building the C++ library as pa…
vyasr May 13, 2022
5a286ab
Point back to the main rapids-cmake branch.
vyasr May 13, 2022
94998e7
Update cpp/CMakeLists.txt
vyasr May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update cpp/CMakeLists.txt
  • Loading branch information
@vyasr
vyasr authored May 13, 2022
commit 94998e718c288b7d93f9bc9898bef28768a90876
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ if(RAFT_COMPILE_LIBRARIES)
set(RAFT_COMPILE_NN_LIBRARY ON)
endif()

if(RAFT_COMPILE_DIST_LIBRARY)
if(RAFT_COMPILE_DIST_LIBRARY OR distance IN_LIST raft_FIND_COMPONENTS)
set(RAFT_ENABLE_cuco_DEPENDENCY ON)
endif()

Expand Down