Update RAFT documentation #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lowener
commented
Aug 4, 2023
lowener
commented
- Various documentation updates on C++ and Python doc, mainly for raft::neighbors
- Add QPS vs Recall plot
Signed-off-by: Mickael Ide <mide@nvidia.com>
cjnolet
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Overall I think the changes look great. I'm holding off on approving only because of the format changes for the code examples in the python docs. We had originally shifted these examples to a different format and I don't know if we want to revert them.
cc @benfred @galipremsagar for their thoughts here.
galipremsagar
approved these changes
Aug 7, 2023
cjnolet
approved these changes
Aug 7, 2023
|
/merge |
Signed-off-by: Mickael Ide <mide@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.