Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raft::bitonic_sort small usage example #1580

Merged
merged 4 commits into from
Jun 10, 2023

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Jun 7, 2023

The template argument Size of raft::util::bitnic_sort must be power-of-two but is set to three in the small usage example in the source code. This PR is only for documentation improvement and does not change any behavior.

@enp1s0 enp1s0 requested a review from a team as a code owner June 7, 2023 09:39
@github-actions github-actions bot added the cpp label Jun 7, 2023
@enp1s0 enp1s0 added doc Documentation non-breaking Non-breaking change and removed cpp labels Jun 7, 2023
@tfeher tfeher requested a review from achirkin June 7, 2023 19:09
@github-actions github-actions bot added the cpp label Jun 8, 2023
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed you're right, thanks for spotting and fixing this!

@cjnolet
Copy link
Member

cjnolet commented Jun 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit 681008e into rapidsai:branch-23.08 Jun 10, 2023
@enp1s0 enp1s0 deleted the fix-bitonic-example branch June 10, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp doc Documentation non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants