Migrate wheel workflow scripts locally #1546
Conversation
divyegala
added
improvement
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
divyegala
changed the title
| cd "${package_dir}" | ||
|
|
||
| # Hardcode the output dir | ||
| python -m pip wheel . -w dist -vvv --no-deps --disable-pip-version-check |
There was a problem hiding this comment.
| python -m pip wheel . -w dist -vvv --no-deps --disable-pip-version-check | |
| python -m pip wheel . -w dist --no-deps --disable-pip-version-check |
Is the verbosity here necessary?
In the past, we've intentionally turned off verbosity for things like pytest because it can make the GHA logs difficult to read.
There was a problem hiding this comment.
I will let @vyasr comment on the verbosity questions
There was a problem hiding this comment.
Yes I was going to raise this point towards the end. I say let's turn off the verbosity for tests, but keep it for builds (i.e. pip wheel -v) That matches what we do for conda and I think that's generally helpful. Test failures tend to be self-contained, so it's enough to see that a single test failure to know what's going on, whereas with builds the real cause can often be hidden (e.g. pip does something wrong in dependency installation which results in compile-time errors).
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
… into local-wheel-build-scripts
|
/merge |
Depends on rapidsai/shared-workflows#97