Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling raft handle from underlying resources #1111

Merged
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
6db8381
Just pushing up what I have
cjnolet Dec 16, 2022
2fac67b
Fix
cjnolet Dec 16, 2022
3995d9f
Still need to figure out how to hide the include/impl
cjnolet Dec 19, 2022
43abfba
Lots of updates
cjnolet Dec 19, 2022
8f72232
Plugging new resources into handle
cjnolet Dec 20, 2022
f4f4711
Adding inlines
cjnolet Dec 20, 2022
e2b0434
Not sure why why some of the tests are crashing. Further debugging
cjnolet Dec 20, 2022
a98736b
Getting tests to run. Most should run now but selection test is still
cjnolet Dec 21, 2022
b13da3f
Reducing the "large test" for selection by an order of magnitude because
cjnolet Dec 21, 2022
66995ba
Merge remote-tracking branch 'rapidsai/branch-23.02' into fea-2302-de…
cjnolet Dec 21, 2022
0dc3be7
Getting remaining tests working
cjnolet Dec 21, 2022
fae3430
Renaming handle -> device_handle and using handle as a typedef for now.
cjnolet Dec 21, 2022
d8e92b5
Adding deprecation note
cjnolet Dec 21, 2022
16295b4
Fixing stream_syncer
cjnolet Dec 21, 2022
6ad702e
Massive rename: raft::core::base_handle -> raft::resources
cjnolet Dec 22, 2022
495f6df
Updating header guard
cjnolet Dec 22, 2022
0459dfb
Adding pragma back to handle.hpp
cjnolet Dec 22, 2022
ebc666a
Improving docs a bit
cjnolet Dec 22, 2022
c112678
Fixing comms test failures
cjnolet Dec 22, 2022
18451c5
Updating developer guide.
cjnolet Dec 22, 2022
c370d2c
Merge branch 'branch-23.02' into fea-2302-decouple_handle_resources
cjnolet Jan 3, 2023
fedd04f
Using inheritance over typedef.
cjnolet Jan 3, 2023
f955ab8
Merge branch 'fea-2302-decouple_handle_resources' of github.com:cjnol…
cjnolet Jan 3, 2023
4793f93
Review updates
cjnolet Jan 4, 2023
645243f
Removing smart pointer from thrust exec policy
cjnolet Jan 4, 2023
e4e2b2b
Using sorted vector for handle resources.
cjnolet Jan 4, 2023
1556360
Sizing arrays to number of resources
cjnolet Jan 4, 2023
a24b332
Moving typedefs to class body
cjnolet Jan 4, 2023
1bdb75f
Fixing assignment for resources so that it properly overwrites
cjnolet Jan 5, 2023
ec1df86
Fixing syntax error
cjnolet Jan 5, 2023
547a5f2
Fixing another syntax error
cjnolet Jan 5, 2023
f983e4d
Reverting thrust exec_policy back to smart pointer to fix segfault.
cjnolet Jan 5, 2023
8105534
Merge branch 'branch-23.02' into fea-2302-decouple_handle_resources
cjnolet Jan 6, 2023
b3b7411
Moving the factory and accessor for cuda stream sync events into the …
cjnolet Jan 9, 2023
b9ffe11
iFixing some naming
cjnolet Jan 9, 2023
ab49460
Fixing syntax error
cjnolet Jan 9, 2023
55ef02f
Merge branch 'branch-23.02' into fea-2302-decouple_handle_resources
cjnolet Jan 10, 2023
83cd3fb
Fixing sub comms
cjnolet Jan 10, 2023
1c7fdcd
Merge branch 'fea-2302-decouple_handle_resources' of github.com:cjnol…
cjnolet Jan 10, 2023
cf15483
Testing comms in handle tests
cjnolet Jan 10, 2023
e7573fd
Removing debug prints from mvg test
cjnolet Jan 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding deprecation note
  • Loading branch information
cjnolet committed Dec 21, 2022
commit d8e92b505cd06cc75dc65394e56b3a11e43c01da
1 change: 1 addition & 0 deletions cpp/include/raft/core/handle.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

namespace raft {

// This will eventually be deprecated in a future version.
using handle_t = raft::device_handle_t;

} // end NAMESPACE raft