Use rapids-cmake for gtest and benchmark dependencies. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I verified that |
|
@RAMitchell @dantegd This is ready for review, when you are able. Thanks! Please merge this before #39. |
trivialfis
reviewed
Jul 21, 2023
trivialfis
approved these changes
Jul 21, 2023
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jul 24, 2023
This PR bumps the gputreeshap tag to include recent changes in rapidsai/gputreeshap#38 and rapidsai/gputreeshap#39. This resolves a cuml build issue with Google Benchmark, described in rapidsai/gputreeshap#38. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: #5512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates gputreeshap to use rapids-cmake to fetch its
gtestandbenchmarkdependencies. Previously, the hardcoded version ofbenchmark1.5.2 was causing problems for me while building cuml. A bug inbenchmarkwas showing up during my build because cuml wasn't able to get the newer 1.8.0 version pinned by rapids-cmake.