Api updates #23
Merged
Api updates #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAMitchell
force-pushed
the
api-updates
branch
from
a65c9fc to
cfa6b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow custom templated implementations of split functions. Can now use single precision or double precision, <= or < conditions or possibly even categorical splits.
API no longer accept phis as a pointer and length, now requiring began and ended iterations. This minor changed interface is significantly more flexible, for example if a user wants to rearrange the output they can pass a thrust permutation iterator. Users may also now pass host memory iterators for output (e.g. std::vector).
Added some functions for tensor indexing, useful in the shap package as outputs need to be transposed into a slightly different format.