Skip to content

Add optional output type variable to rapids-generate-pip-constraints - #273

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:mainfrom
KyleFromNVIDIA:rapids-generate-pip-constraints-output
Aug 5, 2026
Merged

Add optional output type variable to rapids-generate-pip-constraints#273
rapids-bot[bot] merged 2 commits into
rapidsai:mainfrom
KyleFromNVIDIA:rapids-generate-pip-constraints-output

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

@KyleFromNVIDIA
KyleFromNVIDIA requested a review from a team as a code owner August 5, 2026 18:26
@KyleFromNVIDIA
KyleFromNVIDIA requested review from bdice and removed request for a team August 5, 2026 18:26
@KyleFromNVIDIA KyleFromNVIDIA added feature request New feature or request non-breaking Introduces a non-breaking change labels Aug 5, 2026

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it'd be better to have another optional positional argument than a new special-purpose shell variable. But fine with either way you decide to go.

@KyleFromNVIDIA
KyleFromNVIDIA removed the request for review from bdice August 5, 2026 18:32
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 289c9dc into rapidsai:main Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants