rapids-datetime-string: like 'rapids-date-string', but second-precision - #269
Merged
Conversation
32 tasks
jameslamb
force-pushed
the
datetime-string
branch
from
July 31, 2026 15:38
ba78e5a to
22158fc
Compare
jameslamb
marked this pull request as ready for review
July 31, 2026 18:13
bdice
approved these changes
Jul 31, 2026
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#218
Complements rapidsai/shared-workflows#608
For conda builds, RAPIDS projects run
source rapids-date-stringand then thread the environment variable it sets (RAPIDS_DATE_STRING) through into conda package build strings, like this:source rapids-date-string(rapidsai/cuml - ci/build_cpp.sh)
(rapidsai/cuml - conda/recipes/libcuml/recipe.yaml)
In rapidsai/build-planning#218 we're moving from
YYMMDDdate components toYYMMDDhhmmss, and prefer to have a different variable name (RAPIDS_DATETIME_STRING) ... this introduces a newrapids-datetime-stringfor that purpose.Notes for Reviewers
We can remove
rapids-date-stringsoonFrom GitHub searches, it seems to me that
rapids-date-stringand environment variableRAPIDS_DATE_STRINGare only used in CI builds of RAPIDS conda packages.Once all repos are switched over to
rapids-datetime-string/RAPIDS_DATETIME_STRING, we could removerapids-date-string.Nice side benefit... that'll cut out some GitHub API calls from our CI, because builds we'll no longer execute this on every run of a
ci/build_{cpp,python}.shscript:gha-tools/tools/rapids-date-string
Lines 5 to 8 in 02ea00f