[REVIEW] Update Image Entrypoints #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to:
|
ajschmidt8
changed the title
|
@ajschmidt8 good work, let's target for 0.16 and use this PR for testing as we get the same PR builds as in gpuci-build-environment |
raydouglass
approved these changes
Sep 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the entrypoint in our images. The new entrypoint contains some instructions to create a new user with an id that can (optionally) be passed into the container at runtime (i.e.
docker run -e HOST_USER_ID=$(id -u $USER)...). This ensures that volume files created from within the container are writeable/deleteable from users outside of the container.The new entrypoint scripts replace
.run_in_rapids.sh,start_jupyter.sh, and.start_jupyter_run_in_rapids.shso those files have therefore been deleted.Additionally,
sudohas been installed on allbase,runtime, anddevelimages.Finally, the stable DockerHub readmes have been updated as part of this PR.