Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add Container Entrypoint Info #132

Merged
merged 2 commits into from
Aug 3, 2020
Merged

[REVIEW] Add Container Entrypoint Info #132

merged 2 commits into from
Aug 3, 2020

Conversation

aleksficek
Copy link
Contributor

Closes #96

Simple instruction added during runtime container execution.

ajschmidt8
ajschmidt8 requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick request to use official Docker terminology, otherwise looks good!

@aleksficek @ajschmidt8
Update context/.start_jupyter_run_in_rapids.sh
901952d 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@aleksficek aleksficek requested a review from ajschmidt8 August 3, 2020 14:47
@ajschmidt8 ajschmidt8 merged commit 531d810 into branch-0.15 Aug 3, 2020
@ajschmidt8 ajschmidt8 deleted the entrypoint-message branch August 3, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add info message to container entrypoint
2 participants
@aleksficek @ajschmidt8