Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Initial version of devel images with BlazingSQL added #118

Closed

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Jul 7, 2020

This also include the "Welcome to BlazingSQL" notebook repo and updates to /test.sh to run the welcome NB.

Note: There are other NBs in the Welcome repo, but those are not being run since they require additional dependencies. When the runtime images are using the updated RAPIDS meta-packages (specifically an updated notebook deps package), this can be revisited if it's decided the additional dependencies for the extra Blazing NBs are to be included.

@ajschmidt8 - I left the "clean" option in the updated generate script if you ever find that useful. I can remove that if you don't want that code in there.

@rlratzel rlratzel requested review from mike-wendt and ajschmidt8 July 7, 2020 01:11
@rlratzel rlratzel self-assigned this Jul 7, 2020
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BlazingSQL stuff looks good.

Regarding generate_dockerfiles.py:
From our chat on Slack, I'm fine with removing the clean flag for initialize_output_dir. I probably shouldn't have had that functionality in there in the first place.

Since the only way to use that flag is to manually edit generate_dockerfiles.py, I think it's probably best to remove it. This way people aren't encouraged to edit that script. It'll also remove some lines of code which is always good.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. approved. just left one minor suggestion to clean up some comments.

@rlratzel rlratzel changed the title [WIP] Initial version of devel images with BlazingSQL added [REVIEW] Initial version of devel images with BlazingSQL added Aug 5, 2020
Copy link
Contributor

@mike-wendt mike-wendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not create a new image, it changes the core of the devel images. The request made was for a new image that starts with FROM rapidsai/rapidsai-dev or the nightly version. Pushing this to v0.16 until there is a separate image.

@mike-wendt mike-wendt added the DO NOT MERGE Hold off on merging; see PR for details label Aug 25, 2020
@rlratzel
Copy link
Contributor Author

@mike-wendt there's a long internal email thread that ended with "let’s get the devel containers good to go while we work on improving the conda packaging situation", which I interpreted to be what's in this PR. I didn't realize the original request was still what we wanted after that. I can make the change you're asking for, but like you said, it'll now have to wait for 0.16.

@datametrician
Copy link

Let's ask clarifying questions more, and get sign off. This mistake only cost BlazingSQL a few dozen thousand downloads :(

@rlratzel
Copy link
Contributor Author

Let's ask clarifying questions more, and get sign off.

Agreed. Unfortunately, clarification and sign off was the intent of the PR :( but we'll figure out a different way.

@ajschmidt8
Copy link
Member

closing this in favor of #179

@ajschmidt8 ajschmidt8 closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Hold off on merging; see PR for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants