-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Initial version of devel images with BlazingSQL added #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BlazingSQL stuff looks good.
Regarding generate_dockerfiles.py
:
From our chat on Slack, I'm fine with removing the clean
flag for initialize_output_dir
. I probably shouldn't have had that functionality in there in the first place.
Since the only way to use that flag is to manually edit generate_dockerfiles.py
, I think it's probably best to remove it. This way people aren't encouraged to edit that script. It'll also remove some lines of code which is always good.
…blazingdevel, updated generate_dockerfiles.py to remove unused "clean" code, updated blazing partial to use gpuci_conda_retry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. approved. just left one minor suggestion to clean up some comments.
…ranch-0.15-blazingdevel
…ted Maven from running, and which no longer appears to be needed. Merge remote-tracking branch 'upstream/branch-0.15' into branch-0.15-blazingdevel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not create a new image, it changes the core of the devel
images. The request made was for a new image that starts with FROM rapidsai/rapidsai-dev
or the nightly version. Pushing this to v0.16 until there is a separate image.
@mike-wendt there's a long internal email thread that ended with "let’s get the devel containers good to go while we work on improving the conda packaging situation", which I interpreted to be what's in this PR. I didn't realize the original request was still what we wanted after that. I can make the change you're asking for, but like you said, it'll now have to wait for 0.16. |
Let's ask clarifying questions more, and get sign off. This mistake only cost BlazingSQL a few dozen thousand downloads :( |
Agreed. Unfortunately, clarification and sign off was the intent of the PR :( but we'll figure out a different way. |
closing this in favor of #179 |
This also include the "Welcome to BlazingSQL" notebook repo and updates to
/test.sh
to run the welcome NB.Note: There are other NBs in the Welcome repo, but those are not being run since they require additional dependencies. When the
runtime
images are using the updated RAPIDS meta-packages (specifically an updated notebook deps package), this can be revisited if it's decided the additional dependencies for the extra Blazing NBs are to be included.@ajschmidt8 - I left the "clean" option in the updated generate script if you ever find that useful. I can remove that if you don't want that code in there.