Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin dask and distributed for development #1189

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Unpin dask and distributed for development #1189

merged 2 commits into from
Jun 6, 2023

Conversation

galipremsagar
Copy link
Contributor

This PR unpins dask and distributed to >=2023.5.1 for 23.08 development.

xref: rapidsai/cudf#13508

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 2, 2023
@galipremsagar galipremsagar self-assigned this Jun 2, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner June 2, 2023 23:29
@github-actions github-actions bot added the conda conda issue label Jun 2, 2023
@pentschev
Copy link
Member

It seems that none of the builds actually installed a newer Dask/Distributed version, they're all still on 2023.3.2.1. I'm thinking this has to do with the fact that other test dependencies, such as cudf, are pinning to that version. I don't recall if we had this behavior before, but what I'm thinking here is we'll need to update the pin here in Dask-CUDA to >=2023.3.2.1, merge it and then unpin other projects after we have it unpinned here. @galipremsagar WDYT?

@pentschev pentschev mentioned this pull request Jun 5, 2023
Merged
3 tasks
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3f369f9 into rapidsai:branch-23.08 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

Assignees

@galipremsagar galipremsagar

Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @pentschev @raydouglass