-
Notifications
You must be signed in to change notification settings - Fork 118
Serialize Vamana index with SSD sector alignment per MSFT DiskANN format, generate quantized dataset for integration with DiskANN #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 56 commits into
rapidsai:branch-25.08
from
jamxia155:jamxia_vamana_serialize_quantize_build
Jul 15, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test d0aabc6 |
tarang-jain
requested changes
May 2, 2025
…na_serialize_quantize_build
tarang-jain
reviewed
May 14, 2025
tarang-jain
reviewed
May 14, 2025
bkarsin
reviewed
May 16, 2025
bdice
reviewed
Jun 11, 2025
…ntize_build' into jamxia_vamana_serialize_quantize_build
Approving binary size addition to |
…na_serialize_quantize_build
tarang-jain
requested changes
Jun 18, 2025
tarang-jain
approved these changes
Jun 19, 2025
cjnolet
approved these changes
Jul 2, 2025
/merge |
/merge |
gforsyth
approved these changes
Jul 15, 2025
punAhuja
pushed a commit
to SearchScale/cuvs
that referenced
this pull request
Jul 16, 2025
…mat, generate quantized dataset for integration with DiskANN (rapidsai#846) (This supersedes [PR!703](rapidsai#703)) Added an optional input flag to `cuvs::neighbors::vamana::serialize` to dump an input cuvs Vamana index to file with SSD sector alignment. File format follows [MSFT DiskANN](https://github.com/microsoft/DiskANN/blob/main/src/disk_utils.cpp). Using the sector-aligned option also writes out the quantized dataset computed using user-supplied PQ codebooks file and rotation matrix file. Authors: - James Xia (https://github.com/jamxia155) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Tarang Jain (https://github.com/tarang-jain) - Corey J. Nolet (https://github.com/cjnolet) - Gil Forsyth (https://github.com/gforsyth) URL: rapidsai#846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
CMake
cpp
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This supersedes PR!703)
Added an optional input flag to
cuvs::neighbors::vamana::serialize
to dump an input cuvs Vamana index to file with SSD sector alignment. File format follows MSFT DiskANN.Using the sector-aligned option also writes out the quantized dataset computed using user-supplied PQ codebooks file and rotation matrix file.