Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAGRA C example and DlPack docs #51

Merged
merged 55 commits into from
Apr 2, 2024
Merged

CAGRA C example and DlPack docs #51

merged 55 commits into from
Apr 2, 2024

Conversation

divyegala
Copy link
Member

No description provided.

cjnolet and others added 22 commits March 6, 2024 19:28
@cjnolet
Getting a start on the docs
e851903
@cjnolet
Progress
73fa0c8
@cjnolet
Getting CAGRA C++ docs to build
8e48382
@cjnolet
Updating
ca465e6
@cjnolet
Checking in
58743b5
@cjnolet
New docs
d2dd4cc
@cjnolet
Updating build.sh to build the examples
19319d7
@cjnolet
Merge branch 'branch-24.04' into docs_2404-api_docs
f8c1015
@cjnolet
Fixing docs per review
358df75
@cjnolet
Merge branch 'docs_2404-api_docs' of github.com:rapidsai/cuvs into do…
e6bff2b 
…cs_2404-api_docs
@cjnolet
Merge branch 'branch-24.04' into docs_2404-api_docs
5ac765f
@cjnolet
Removing developer guide. That's unneeded int the docs
64d594b
@cjnolet
Stubbing out quick start guide
620e080
@cjnolet
Adding quick start
f1f671f
@cjnolet
Checking in
31d014c
@cjnolet
Renaming quick_start to getting started
f69e86e
@cjnolet
Removing osexamples
0afe86b
@cjnolet
Fixing package issuey
929e9b4
@cjnolet
Breaking apart getting started guide
77e1cbe
@cjnolet
MOre updates
3a79601
@cjnolet
Merge remote-tracking branch 'origin/branch-24.04' into docs_2404-api…
c9a50fe 
…_docs
@divyegala
Dlpack docs
86ad684
@divyegala divyegala added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Mar 12, 2024
@divyegala divyegala requested a review from a team as a code owner March 12, 2024 21:35
@divyegala divyegala changed the base branch from branch-24.04 to docs_2404-api_docs March 12, 2024 21:35
dantegd
dantegd requested changes Mar 12, 2024
View reviewed changes
divyegala and others added 9 commits March 13, 2024 17:04
@divyegala
restructure examples
a7d52f9
@divyegala @cjnolet
Update docs/source/interoperability.rst
4ca00b6 
Co-authored-by: Corey J. Nolet <cjnolet@gmail.com>
@cjnolet
Merge branch 'branch-24.04' into dlpack-docs
504ce4a
@divyegala
add get_dlpack.cmake
36d8520
@divyegala
dlpack headers include
b50ffbe
@KyleFromNVIDIA @divyegala
Replace local copyright check with pre-commit-hooks verify-copyright (r…
de155b9 
…apidsai#48)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#48
@bdice @divyegala
Remove unused get_*.cmake files. (rapidsai#57)
be206d8 
This PR removes some unused `get_*.cmake` files. I know cuVS may need to add some of these back as functionality is migrated from RAFT. As that happens, I would like to copy them again from the latest versions in RAFT.

Specifically, files like `get_thrust.cmake` are outdated (we are moving to `rapids_cpm_cccl` and `rapids_cpm_thrust` is deprecated) so this will reduce the maintenance burden for CMake / build system developers in the interim period.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Micka (https://github.com/lowener)

URL: rapidsai#57
@benfred @divyegala
Add ability to allocate with RMM to the c-api and rust api (rapidsai#56)
2b18f49 
Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#56
@divyegala
use cuvsRMMAlloc/cuvsRMMFree
eb7c496
@divyegala divyegala requested a review from a team as a code owner March 20, 2024 20:54
dantegd
dantegd requested changes Mar 21, 2024
View reviewed changes
examples/build.sh

if [[ ${CUVS_REPO_REL} != "" ]]; then
CUVS_REPO_PATH="`readlink -f \"${CUVS_REPO_REL}\"`"
EXTRA_CMAKE_ARGS="${EXTRA_CMAKE_ARGS} -DCPM_cuvs_SOURCE=${CUVS_REPO_PATH}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to provide either a default value for CUVS_REPO_PATHor document it in the readme of the example. I didn't check, but are we documenting the build.sh example in the example readme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a default where if a repo path is not provided then the examples will try to look for the build directory and pick up the shared libraries from there.

@cjnolet cjnolet assigned divyegala and unassigned cjnolet Apr 2, 2024
divyegala and others added 3 commits April 2, 2024 17:01
@divyegala @dantegd
Apply suggestions from code review
12362b1 
Co-authored-by: Dante Gama Dessavre <dante.gamadessavre@gmail.com>
@divyegala
cuvs docs
8626c15
@divyegala
address review
80b50f5
dantegd
dantegd approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from my side

@cjnolet
Copy link
Member

cjnolet commented Apr 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit d62e1ce into rapidsai:branch-24.04 Apr 2, 2024
56 of 57 checks passed
benfred pushed a commit to benfred/cuvs that referenced this pull request Apr 5, 2024
@divyegala @benfred
CAGRA C example and DlPack docs (rapidsai#51)
3d5a651 
Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Bradley Dice (https://github.com/bdice)
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#51
difyrrwrzd added a commit to difyrrwrzd/cuvs that referenced this pull request Aug 10, 2024
@difyrrwrzd
CAGRA C example and DlPack docs (#51)
db07172 
Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Bradley Dice (https://github.com/bdice)
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai/cuvs#51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred left review comments

@dantegd dantegd dantegd approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@divyegala divyegala

Labels
CMake doc Improvements or additions to documentation non-breaking Introduces a non-breaking change Python
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@divyegala @cjnolet @benfred @dantegd @KyleFromNVIDIA @bdice