Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve dependency-file-generator warning, rapids-build-backend followup #185

Merged
merged 2 commits into from
Jun 13, 2024
Merged

resolve dependency-file-generator warning, rapids-build-backend followup #185

merged 2 commits into from
Jun 13, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Since #145 was merged, we've made some small adjustments to the approach for rapids-build-backend. This catches cuvs up with those changes:

  • consolidates version-handling in ci/ scripts
  • uses --file-key instead of --file_key in rapids-dependency-file-generator calls

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 12, 2024
@jameslamb jameslamb requested a review from a team as a code owner June 12, 2024 19:47
@jameslamb jameslamb requested a review from AyodeAwe June 12, 2024 19:47
@github-actions github-actions bot added the ci label Jun 12, 2024
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 771cc91 into rapidsai:branch-24.08 Jun 13, 2024
55 checks passed
@jameslamb jameslamb deleted the more-rbb branch June 13, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice