Use JIT LTO compilation for CAGRA search kernels #1320
Conversation
divyegala
added
feature request
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
| enable_check_generated_files: false | ||
| ignored_pr_jobs: "telemetry-summarize" | ||
| conda-cpp-build: | ||
| needs: checks |
There was a problem hiding this comment.
Why has this been removed? wheel-build-libcuvs still has it.
There was a problem hiding this comment.
Just to run CI, I couldn't get the style checker to pass because pre-commit for me locally does not raise any CMake styling issue.
| - libcurand | ||
| - libcusolver | ||
| - libcusparse | ||
| - libnvjitlink-dev |
There was a problem hiding this comment.
Why does this have the -dev suffix? The others above in this section don't.
| - libcusparse-dev | ||
| run: | ||
| - ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }} | ||
| - libnvjitlink-dev |
There was a problem hiding this comment.
Why does this have the -dev suffix? Headers shouldn't be needed at runtime.
There was a problem hiding this comment.
That's a good point, we probably only need libnvjitlink at run.
| get_filename_component(obj_name ${obj} NAME_WE) | ||
| get_filename_component(obj_dir ${obj} DIRECTORY) | ||
|
|
||
| if(obj_ext MATCHES ".fatbin") |
There was a problem hiding this comment.
| if(obj_ext MATCHES ".fatbin") | |
| if(obj_ext MATCHES "\\.fatbin$") |
| # ============================================================================= | ||
|
|
||
| set(file_contents) | ||
| foreach(obj ${OBJECTS}) |
There was a problem hiding this comment.
| foreach(obj ${OBJECTS}) | |
| foreach(obj IN LISTS OBJECTS) |
| - output_types: conda | ||
| packages: | ||
| - libcuvs-tests==25.10.*,>=0.0.0a0 | ||
| depends_on_libnvjitlink-dev: |
There was a problem hiding this comment.
We typically don't put hyphens in dependency set names:
| depends_on_libnvjitlink-dev: | |
| depends_on_libnvjitlink_dev: |
|
@KyleFromNVIDIA thanks Kyle for your review! Unfortunately, this PR is still in draft state and needs a lot of work and benchmarking to be done. However, I will attempt to answer your review during the dev process. |
No description provided.