Refactor knn graph build params to remove graph_build_types.hpp
#1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsolp
added
improvement
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
jinsolp
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
cjnolet
reviewed
Aug 14, 2025
| #include <optional> | ||
| #include <variant> | ||
|
|
||
| namespace cuvs::neighbors::graph_build_params { |
There was a problem hiding this comment.
I wonder- could we put these in all_neighbors.hpp and include in cagra.hpp? I know it sounds awkward to do this today, but if we consider that CAGRA will be using all_neighbors soon to build the underlying all-neighbors graph then that'll feel more natural. We could even add a comment in cagra.hpp where we include all_neighbors.hpp, stating that CAGRA shoudl beusing that soon (and maybe link to a Github issue so we remember to remove the comment eventually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #1233