Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to Fix Broken C++ Build After cudftestutil is Made a Shared Lib #996

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Attempt to Fix Broken C++ Build After cudftestutil is Made a Shared Lib #996

merged 7 commits into from
Mar 15, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 15, 2023

Description

This PR aims to fix broken C++ build.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner March 15, 2023 16:39
@isVoid isVoid requested a review from vyasr March 15, 2023 16:39
@isVoid isVoid added the bug Something isn't working label Mar 15, 2023
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 15, 2023
@isVoid isVoid added non-breaking Non-breaking change and removed cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 15, 2023
bdice
bdice reviewed Mar 15, 2023
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 15, 2023
@isVoid isVoid requested a review from a team as a code owner March 15, 2023 20:48
@github-actions github-actions bot added the conda Related to conda and conda configuration label Mar 15, 2023
bdice
bdice approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine if you fix the copied cudf references.

cpp/cmake/thirdparty/get_gtest.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_gtest.cmake Outdated Show resolved Hide resolved
@isVoid
Copy link
Contributor Author

isVoid commented Mar 15, 2023

/merge

msadang
msadang approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapids-bot rapids-bot bot merged commit 3aefd4e into rapidsai:branch-23.04 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@bdice bdice bdice approved these changes

@msadang msadang msadang approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

Assignees
No one assigned
Labels
bug Something isn't working cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isVoid @harrism @bdice @msadang