Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apply_boolean_mask Feature #918

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Add apply_boolean_mask Feature #918

merged 4 commits into from
Feb 16, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 13, 2023 •
edited
Loading

Description

This PR makes geodataframe supports subsetting via boolean masks. closes #927

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner February 13, 2023 16:32
@isVoid isVoid requested a review from thomcom February 13, 2023 16:32
@isVoid isVoid self-assigned this Feb 13, 2023
@isVoid isVoid added the 3 - Ready for Review Ready for review by team label Feb 13, 2023
@github-actions github-actions bot added the Python Related to Python code label Feb 13, 2023
@isVoid isVoid added feature request New feature or request non-breaking Non-breaking change labels Feb 13, 2023
@isVoid isVoid linked an issue Feb 14, 2023 that may be closed by this pull request
[FEA]: Support boolean mask subsetting in GeoDataFrame/GeoSeries #927
Closed
@isVoid isVoid requested a review from harrism February 14, 2023 18:53
@thomcom
Copy link
Contributor

thomcom commented Feb 14, 2023

I'm pretty sure that boolean masking already worked on GeoSeries, but I can see it not working for GeoDataFrame. Did you find a problem with that implementation? The additions to GeoColumn and GeoSeries may be duplication...

@isVoid
Copy link
Contributor Author

isVoid commented Feb 14, 2023

You are right. They are supported by the iloc indexer. Removing.

@isVoid
Copy link
Contributor Author

isVoid commented Feb 14, 2023 •
edited
Loading

Updated geodataframe implementation to depend on geoseries' iloc.

@isVoid
Copy link
Contributor Author

isVoid commented Feb 16, 2023

/merge

@rapids-bot rapids-bot bot merged commit ceb4758 into rapidsai:branch-23.04 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Support boolean mask subsetting in GeoDataFrame/GeoSeries
3 participants
@isVoid @thomcom @harrism