Use vector equivalence macros consistently in header-only API tests. #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
bug
harrism
requested review from
isVoid and
trxcllnt
and removed request for
cwharris and
zhangjianting
Codecov ReportBase: 92.55% // Head: 92.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #873 +/- ##
=============================================
Coverage 92.55% 92.55%
=============================================
Files 24 24
Lines 1008 1008
=============================================
Hits 933 933
Misses 75 75 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
trxcllnt
approved these changes
Jan 25, 2023
isVoid
approved these changes
Jan 25, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates all header-only API tests to consistently use the
CUSPATIAL_EXPECT_VECTORS_EQUIVALENTandCUSPATIAL_EXPECT_VEC2D_PAIRS_EQUIVALENTmacros.Fixes #638. (However there wasn't really a correctness issue.)
Checklist