Deprecate shapefile reader #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
libcuspatial
harrism
added
feature request
harrism
requested review from
thomcom and
isVoid
and removed request for
cwharris
github-actions
bot
added
libcuspatial
Codecov ReportBase: 92.55% // Head: 92.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #872 +/- ##
================================================
+ Coverage 92.55% 92.58% +0.02%
================================================
Files 24 24
Lines 1008 1011 +3
================================================
+ Hits 933 936 +3
Misses 75 75
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
trxcllnt
approved these changes
Jan 25, 2023
isVoid
approved these changes
Jan 25, 2023
thomcom
approved these changes
Jan 30, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cuSpatial's C++-based shapefile reader is limited. It can only load polygons (not multipolygons). It was written before cuSpatial supported GeoArrow data format and before it could ingest data from GeoPandas directly. It is better to use GeoPandas or other libraries to load data into cuSpatial. Dropping
read_polygon_shapefileand its C++ implementation allows dropping the libcuspatial dependency on GDAL, which may help with publishing PIP wheels, which is a priority.This PR simply adds deprecation warnings / decorators to the Python and C++
read_polygon_shapefilefunctions and documentation, and updates the Python user guide to mention deprecation.The plan is to remove these functions and tests that depend on them in 23.04.
Checklist