Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update memory_usage with tweaked sizes #855

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Update memory_usage with tweaked sizes #855

merged 1 commit into from
Dec 13, 2022

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Dec 13, 2022 •
edited
Loading

Upstream in cudf the memory_usage method seems to have changed its reporting size slightly.

This breaks CI in cuSpatial. This PR changes the memory usage test result values to reflect the minor update in cudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@thomcom thomcom added tests Relating to tests and test automation non-breaking Non-breaking change labels Dec 13, 2022
@thomcom thomcom requested a review from a team as a code owner December 13, 2022 14:28
@thomcom thomcom self-assigned this Dec 13, 2022
@github-actions github-actions bot added the Python Related to Python code label Dec 13, 2022
@thomcom thomcom added bug Something isn't working and removed Python Related to Python code labels Dec 13, 2022
@thomcom
Copy link
Contributor Author

thomcom commented Dec 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 959aa0b into rapidsai:branch-23.02 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@harrism harrism Awaiting requested review from harrism

Assignees

@thomcom thomcom

Labels
bug Something isn't working non-breaking Non-breaking change tests Relating to tests and test automation
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomcom @isVoid